feat: change who was involved when rewording an event (#1190) #1212

Merged

claude-bot merged 7 commits from feat/1190-event-people into main 2026-10-17 11:34:08 +00:00

Conversation 0 Commits 7 Files changed 23 +1382 -40

claude-bot commented 2026-10-17 11:02:21 +00:00

Collaborator

Copy link

Fixes #1190: the GM can change who was involved when rewording an event.

• Migration a1190e7e0a01 (now revises a1191b0e5701, the line of the night) adds session_pending_corrections.actors and session_beats.gm_original_actors, both nullable TEXT[].
• Saving a reword (PUT …/pending-corrections/{beat_id}) can carry actors:
  • omitted means unchanged;
  • [] means nobody;
  • at most 12 names of 100 characters each.
• A recompose copies the corrected people, keeps the model's list in gm_original_actors, and the next summary is composed from them.
• The GM-only picker, GET /api/sessions/{id}/event-people?q=, lists characters, then members, then table-visible NPC pages. Free names are accepted.
• Screen: the Reword box shows the people as chips with an "Add someone" combobox, plus "No one in particular" and free names. A changed row is marked "People changed" and shows the model's original people to the GM.

Tests:

• backend: 493 passed across the review, corrections, recompose and event-log suites;
• vitest: ReviewView 65 of 65 when run alone;
• journey J5 on docker-test: 26 passed on desktop, phone and keyboard.

CATALOGUE row renumbered to SE-163 (SE-160 to SE-162 are the line of the night's).

🤖 Generated with Claude Code

Fixes #1190: the GM can change who was involved when rewording an event. - **Migration `a1190e7e0a01`** (now revises `a1191b0e5701`, the line of the night) adds `session_pending_corrections.actors` and `session_beats.gm_original_actors`, both nullable TEXT[]. - **Saving a reword** (`PUT …/pending-corrections/{beat_id}`) can carry `actors`: - omitted means unchanged; - `[]` means nobody; - at most 12 names of 100 characters each. - **A recompose copies the corrected people,** keeps the model's list in `gm_original_actors`, and the next summary is composed from them. - **The GM-only picker,** `GET /api/sessions/{id}/event-people?q=`, lists characters, then members, then table-visible NPC pages. Free names are accepted. - **Screen:** the Reword box shows the people as chips with an "Add someone" combobox, plus "No one in particular" and free names. A changed row is marked "People changed" and shows the model's original people to the GM. Tests: - backend: 493 passed across the review, corrections, recompose and event-log suites; - vitest: ReviewView 65 of 65 when run alone; - journey J5 on docker-test: 26 passed on desktop, phone and keyboard. CATALOGUE row renumbered to SE-163 (SE-160 to SE-162 are the line of the night's). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 7 commits 2026-10-17 11:02:21 +00:00

feat(webapp): change who was involved when rewording an event (#1190) ... 6de82605ee

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test: event people picker uses a real wiki type; ruff format (#1190) ... 18e79d379d

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(webapp): reword an event's people in the Review tab (#1190) ... fcc07fea7b

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

test(e2e): add a person while rewording an event (#1190) ... 1631125825

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

fix(webapp): the people list overlays the form, so closing it does not move Save (#1190) ... 7f078f9a2d

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

test: list the Reword picker's title read in the title-reader list (#1190) ... 295cb7a187

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge main into feat/1190-event-people; its migration follows a1191b0e5701 ... 96fd18489e

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-10-17 11:02:23 +00:00

claude-bot merged commit 405df641b1 into main 2026-10-17 11:34:08 +00:00

claude-bot referenced this pull request from a commit 2026-10-17 11:34:09 +00:00

Merge PR #1212: change who was involved when rewording an event (#1190)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1212

No description provided.