rbrooks/Quest-Board

Watch

Fork 0

fix(webapp): the wiki editor's [[ menu opens at the caret (#1261) #1262

Closed

claude-bot wants to merge 0 commits from fix/1261-editor-link-menu into main

claude-bot commented

2026-10-28 15:08:52 +00:00

Collaborator

Closes #1261. For v4.6.2.

The [[ link menu (.ed-ac) stood at a fixed spot under the text box's top edge. On any page with text it covered the first lines and the link being typed (the owner's screenshot: [[Vel on line 2, with the menu over line 1).

src/wiki/caretPoint.js: the caret's pixel position in a textarea, measured with a hidden mirror that has the same box, font and wrapping. Returns null where there is no layout.
EditorPane: in a layout effect (and on the text box's scroll), the menu goes 4px under the caret's line, is clamped inside the pane, and flips above the line when there isn't room below. With null, the stylesheet's old place stands, which is also what jsdom gets.
Test EditorPane.linkmenu.test.jsx stubs caretPoint and the box sizes and checks below, clamp, flip and the null fallback. Two of its three tests fail on the old code. Editor.test.jsx and EditorPane.bringin.test.jsx still pass (51 tests). eslint: no errors.

Not verified in a real browser. No browser is available in this session. The rc on dev is where to see it, since the mirror measurement is the part jsdom can't exercise.

🤖 Generated with Claude Code

Closes #1261. For **v4.6.2**. The `[[` link menu (`.ed-ac`) stood at a fixed spot under the text box's top edge. On any page with text it covered the first lines and the link being typed (the owner's screenshot: `[[Vel` on line 2, with the menu over line 1). - `src/wiki/caretPoint.js`: the caret's pixel position in a textarea, measured with a hidden mirror that has the same box, font and wrapping. Returns `null` where there is no layout. - `EditorPane`: in a layout effect (and on the text box's scroll), the menu goes 4px under the caret's line, is clamped inside the pane, and flips above the line when there isn't room below. With `null`, the stylesheet's old place stands, which is also what jsdom gets. - Test `EditorPane.linkmenu.test.jsx` stubs `caretPoint` and the box sizes and checks below, clamp, flip and the null fallback. Two of its three tests fail on the old code. `Editor.test.jsx` and `EditorPane.bringin.test.jsx` still pass (51 tests). eslint: no errors. **Not verified in a real browser.** No browser is available in this session. The rc on dev is where to see it, since the mirror measurement is the part jsdom can't exercise. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit

2026-10-28 15:08:52 +00:00

fix(webapp): the wiki editor's [[ menu opens at the caret (#1261 )

CI / Bot/backend version sync (pull_request) Successful in 23s

Details

CI / Backend lint (ruff) (pull_request) Successful in 31s

Details

CI / Which journeys does this change need? (pull_request) Successful in 18s

Details

CI / Does this change touch the recording path? (pull_request) Successful in 18s

Details

CI / Feedback site tests (pull_request) Successful in 44s

Details

CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been skipped

Details

CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 1m4s

Details

CI / Bot tests and audit (pull_request) Successful in 2m8s

Details

CI / Docker image build (pull_request) Successful in 4m47s

Details

CI / Frontend (shard 2/2) (pull_request) Successful in 7m41s

Details

CI / Frontend (shard 1/2) (pull_request) Successful in 9m15s

Details

CI / End-to-end journeys (desktop) (pull_request) Successful in 13m26s

Details

CI / Backend migration, tests, and audit (pull_request) Successful in 32m46s

Details

884d962130

.ed-ac stood at a fixed spot under the text box's top edge, so on a page
with text it covered the first lines and the link being typed. caretPoint()
measures the caret with a hidden mirror of the textarea, and EditorPane
places the menu under that line, inside the pane, flipping above the line
when there is no room below and following the box as it scrolls. Where
nothing can be measured the stylesheet's place stands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot referenced this pull request

2026-10-28 18:10:33 +00:00

v4.6.2: the map, as planned (#1263, #1260, #1261) #1266

claude-bot commented

2026-11-05 18:31:56 +00:00

Author

Collaborator

Closing as landed. This branch has no commits that aren't on main: src/wiki/caretPoint.js and EditorPane.linkmenu.test.jsx are in main, they reached it with 4.6.2, and #1261 is closed.

Closing as landed. This branch has no commits that aren't on main: `src/wiki/caretPoint.js` and `EditorPane.linkmenu.test.jsx` are in main, they reached it with 4.6.2, and #1261 is closed.

claude-bot closed this pull request

2026-11-05 18:31:57 +00:00