feat(feedback): the names page split by kind, and eighteen new generators to rate (#1257) #1329

Merged

claude-bot merged 5 commits from feat/1257-name-splits into main 2026-11-03 19:28:45 +00:00

Conversation 0 Commits 5 Files changed 6 +943 -82

claude-bot commented 2026-11-03 16:23:30 +00:00

Collaborator

Copy link

Part of #1257: the owner's notes after a first pass, and their answer to Q219, "all of them". This is live on the feedback site (data backed up first). It carries #1322's commit (the admin readout's "Who has rated"), so it supersedes #1322.

Splits

• Organisations becomes Guilds; Companies (the most patterns: family firms, shops and workshops, mills and tanneries, carrying and shipping houses, moneylenders, chartered and mercenary companies); and Orders & secret societies.
• Taverns & inns becomes Taverns and Inns & lodgings (rests, lodges, coaching inns, waystations, boarding houses).
• Ships becomes Small boats, Merchant ships and Warships.
• Landscape becomes Forests & woods; Mountains & hills; Caves & the deep; Rivers, lakes & falls; Coasts & seas; and Marshes, moors & plains.
• Settlements becomes Hamlets & villages, Towns and Cities.

New: Kobold, Leshy, Catfolk, Ratfolk, Kitsune, Tengu, Dragonborn, Tiefling; Noble houses (seat and motto); Deities & saints; Streets, districts & landmarks; Temples & shrines; Books, scrolls & documents; Magic items & named weapons; Horses & animals; Battles & historical events; Festivals & holidays. 44 styles in all.

Votes already cast stay valid:

• org, inn, ship, geo and town stay accepted on the server (RETIRED_NAME_STYLES), but the page no longer offers them.
• The admin readout lists them under "Retired (before the split, 3 Nov)" with their counts.
• A bug is fixed along the way: the page used to drop a rater's notes on any style it no longer offered. It now re-sends them.

Names that are said well and aren't borrowed:

• Made words refuse a doubled letter or an echo at a join.
• New filters keep out famous inns, ships and places (the Prancing Pony, Waterdeep, Sandpoint), the rulebooks' example dragonborn and tiefling names, iconic Pathfinder characters, and tiefling joins that land on plain words.
• Labels and order now come from one file, static/name-styles.js.

Checked:

• The feedback-site tests on the merged branch: 177 passed.
• A render of all 44 tabs and the admin readout, including at 390 px.
• 48 samples per new style were read and fixed: names-samples.txt in the session scratchpad.
• Merged with main and the lane 6j design branch, so the live site keeps lanes 6i and 6j.

🤖 Generated with Claude Code

Part of #1257: the owner's notes after a first pass, and their answer to Q219, "all of them". **This is live on the feedback site** (data backed up first). It carries #1322's commit (the admin readout's "Who has rated"), so it supersedes #1322. **Splits** - **Organisations** becomes Guilds; Companies (the most patterns: family firms, shops and workshops, mills and tanneries, carrying and shipping houses, moneylenders, chartered and mercenary companies); and Orders & secret societies. - **Taverns & inns** becomes Taverns and Inns & lodgings (rests, lodges, coaching inns, waystations, boarding houses). - **Ships** becomes Small boats, Merchant ships and Warships. - **Landscape** becomes Forests & woods; Mountains & hills; Caves & the deep; Rivers, lakes & falls; Coasts & seas; and Marshes, moors & plains. - **Settlements** becomes Hamlets & villages, Towns and Cities. **New:** Kobold, Leshy, Catfolk, Ratfolk, Kitsune, Tengu, Dragonborn, Tiefling; Noble houses (seat and motto); Deities & saints; Streets, districts & landmarks; Temples & shrines; Books, scrolls & documents; Magic items & named weapons; Horses & animals; Battles & historical events; Festivals & holidays. **44 styles in all.** **Votes already cast stay valid:** - `org`, `inn`, `ship`, `geo` and `town` stay accepted on the server (`RETIRED_NAME_STYLES`), but the page no longer offers them. - The admin readout lists them under "Retired (before the split, 3 Nov)" with their counts. - A bug is fixed along the way: the page used to drop a rater's notes on any style it no longer offered. It now re-sends them. **Names that are said well and aren't borrowed:** - Made words refuse a doubled letter or an echo at a join. - New filters keep out famous inns, ships and places (the Prancing Pony, Waterdeep, Sandpoint), the rulebooks' example dragonborn and tiefling names, iconic Pathfinder characters, and tiefling joins that land on plain words. - Labels and order now come from one file, `static/name-styles.js`. **Checked:** - The feedback-site tests on the merged branch: 177 passed. - A render of all 44 tabs and the admin readout, including at 390 px. - 48 samples per new style were read and fixed: `names-samples.txt` in the session scratchpad. - Merged with main and the lane 6j design branch, so the live site keeps lanes 6i and 6j. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 7 commits 2026-11-03 16:23:30 +00:00

feat(feedback): the readout says who has rated, and what (#1257) ... 36bc3e6d5e

Asked for on 2 Nov: with three raters the owner could not tell whether
they were all one person. A table of raters (the name they gave, the
link that saved it, marks, the styles marked with notes, last saved),
and a "Rated by" line on each style.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(design): lane 6j, facts the session may have changed (#1280) ... fd7d4eacaf

Suggested wiki updates gains "Facts that may have changed": one card
per page, old -> new with the quote from the recording, and Use it,
Change it... or Not this one. The editor shows a pending suggestion
under its fact. Status, Allegiances, Ruler, Leader and Owner first.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(design): D323–D326, facts the session may have changed (#1280) ... ae62f6fd89

The owner's answers to Q214–Q217.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(feedback): the names page splits five styles and adds eighteen more (#1257) ... b42c223491

The owner's notes after a first pass (3 Nov):
- Organisations becomes Guilds, Companies (the most patterns: shops,
  family firms, works, partners, trading houses, chartered companies,
  a few free companies) and Orders & secret societies.
- Taverns & inns becomes Taverns and Inns & lodgings (rests, old
  houses turned inns, lodges, coaching inns, waystations).
- Ships becomes Small boats, Merchant ships and Warships.
- Landscape becomes Forests & woods, Mountains & hills, Caves & the
  deep, Rivers, lakes & falls, Coasts & seas, and Marshes, moors &
  plains, each with its own words.
- Settlements becomes Hamlets & villages, Towns and Cities.

And the owner's answer to Q219 (all of them): kobold, leshy, catfolk,
ratfolk, kitsune, tengu, dragonborn and tiefling names; noble houses
with seat and motto; deities and saints; streets, districts and
landmarks; temples and shrines; books and documents; magic items and
named weapons; horses and animals; battles and history; festivals.

Made words refuse echoes and doubled letters at the join; the
rulebooks' example names and famous inns and places are never drawn.

The five old styles stay valid on the server (RETIRED_NAME_STYLES):
a rater's old marks and notes are re-sent untouched (notes on retired
styles were dropped before) and the readout lists them under
"Retired (before the split, 3 Nov)". Labels live once, in
static/name-styles.js, read by the page and the readout.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(feedback): a warship's realm name must flow, and no Mount Tarn (#1257) ... 5866472fa0

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into feat/1257-name-splits ... a8cf73cdb2

# Conflicts:
#	tools/feedback-site/tests/test_app.py

Merge remote-tracking branch 'origin/design/1280-fact-suggestions' into feat/1257-name-splits 3f31f2dc06

claude-bot merged commit dbc9c3ee1a into main 2026-11-03 19:28:45 +00:00

claude-bot referenced this pull request from a commit 2026-11-03 19:28:45 +00:00

Merge pull request 'feat(feedback): the names page split by kind, and eighteen new generators (#1257)' (#1329)

claude-bot referenced this pull request 2026-11-03 19:29:04 +00:00

feat(feedback): the readout says who has rated, and what (#1257) #1322

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1329

No description provided.