rbrooks/Quest-Board
Watch
1
0
Fork
You've already forked Quest-Board
 0
Code Issues 58 Pull requests 7 Projects Releases 76 Packages Wiki Activity Actions

feat(feedback): the names page after the owner's ratings, and lanes 6k and 6l (#1257, #1328) #1330

Closed
claude-bot wants to merge 0 commits from feat/1257-rating-fixes into main
pull from: feat/1257-rating-fixes
merge into: rbrooks:main
Conversation 1 Commits - Files changed -
claude-bot commented 2026-11-03 19:43:58 +00:00
Collaborator
Copy link

Part of #1257 and #1328. Live on the feedback site (data backed up first).

The names page after the ratings. The "The…" shares were measured over 4,000 draws per style.

  • Forests (19% "The…"): no Chase, Hanger, Holt, Brake, Weald, Thicket, Copse or Wilds, and no plain tree-plus-feature names. They're mostly named Forest or Wood.
  • Rivers & lakes (19%): no Force, Foss, Leap or Spout (waterfalls are Falls), and never "The X Lake".
  • Coasts (19%): fewer "The…", and no Ness.
  • Realms (25%): no Reach, Marches or "Old Empire"; "New …" rarely. Names must pass the flow check and can't be a real first name.
  • Every landscape: "The " is kept well under a third.
  • Human (Hearthland): the heavy given-name parts are gone (Cyn-, Leod-, Bald-, Mild-, -swith, and the -er and -ley endings), and family names pass the join check.
  • Elvish: no "of the …" titles, and a tighter vowel rule.
  • Others: taverns have no "Snug" and no "Prancing"; mountains have no "Heights" or "-side" on a made place name; there are no "-side" forests or lakes, and no plain-word rivers used as names.

Lane 6l, Names in Prep: the drawer with Kind and a Style that changes with it, ten names a set, Save to the wiki, and Describe (only with an AI), with the no-AI and empty states. Three questions are on the Questions page (Q229–Q231).

Lane 6k, Fill it in (#1328): merged in from its design branch so the live site keeps it, including the owner's phone-layout fixes (the die beside and level with the value).

Checked: the feedback-site tests on the merged branch (183 passed); 60 samples per changed style, read and fixed; lane 6l at 390 px in both themes (no errors, no sideways scroll); every live page returns 200 after the deploy.

🤖 Generated with Claude Code

Part of #1257 and #1328. **Live on the feedback site** (data backed up first). **The names page after the ratings.** The "The…" shares were measured over 4,000 draws per style. - **Forests (19% "The…"):** no Chase, Hanger, Holt, Brake, Weald, Thicket, Copse or Wilds, and no plain tree-plus-feature names. They're mostly named Forest or Wood. - **Rivers & lakes (19%):** no Force, Foss, Leap or Spout (waterfalls are Falls), and never "The X Lake". - **Coasts (19%):** fewer "The…", and no Ness. - **Realms (25%):** no Reach, Marches or "Old Empire"; "New …" rarely. Names must pass the flow check and can't be a real first name. - **Every landscape:** "The <adj> <noun>" is kept well under a third. - **Human (Hearthland):** the heavy given-name parts are gone (Cyn-, Leod-, Bald-, Mild-, -swith, and the -er and -ley endings), and family names pass the join check. - **Elvish:** no "of the …" titles, and a tighter vowel rule. - **Others:** taverns have no "Snug" and no "Prancing"; mountains have no "Heights" or "-side" on a made place name; there are no "-side" forests or lakes, and no plain-word rivers used as names. **Lane 6l, Names in Prep:** the drawer with Kind and a Style that changes with it, ten names a set, Save to the wiki, and Describe (only with an AI), with the no-AI and empty states. Three questions are on the Questions page (Q229–Q231). **Lane 6k, Fill it in (#1328):** merged in from its design branch so the live site keeps it, including the owner's phone-layout fixes (the die beside and level with the value). **Checked:** the feedback-site tests on the merged branch (183 passed); 60 samples per changed style, read and fixed; lane 6l at 390 px in both themes (no errors, no sideways scroll); every live page returns 200 after the deploy. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Roll a page's empty facts offline, and the people and places they
point to: dice in the editor, Roll the rest, the list of pages a roll
would make before saving (one level deep), a whole company from size
and trade, Make it a page from the names page, a quick NPC at the
table, and the fact tables for review.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The owner's note: three compact rows (the fact's name; the value with
its die or Roll again; Who sees it with Remove) instead of five, with
no overlap.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Measured: the die sat 6-10 px above the field and 3 px shorter. It now
starts level with the field and is as tall, on a phone and on a wide
screen; Roll again centres in the same space.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Forests: no Chase, Hanger, Holt, Brake, Weald, Thicket, Copse or
  Wilds, and no bare tree-and-feature names; mostly a place's forest
  or wood, sometimes the Wood of a river, about 18% "The ...".
- Rivers and lakes: Falls, never Force, Foss, Leap or Spout; Heron
  Lake, never "The Heron Lake"; Loch and River forms; about 20% "The".
- Coasts: about 20% "The", bare forms like Heron Bay, no Ness.
- Realms: mostly the name alone (about 25% "The"), no Reach, Marches
  or Old Empire, a rare New realm; sayable, and not a real first name.
- Every landscape: "The <adj> <noun>" about a fifth; a place-name
  helper retries failed joins so they don't tilt the mix.
- Hearthland: no Cyn-, Leod-, Bald-, Mild-, Hild- given parts, no
  -swith, -thryth, -gyth, -den, -er or -ley endings.
- Elvish: no "of the ..." titles; a sound rule against vowel pile-ups
  and four-syllable names.
- Taverns: no Snug. Mountains: no Heights after a made place name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Kind of name and a Style that follows it (the system's peoples first),
ten names from the generator, Save to the wiki and Describe (only with
an AI), Another set; the no-AI, described and nothing-to-offer states,
a phone, and the table of styles per kind. Three questions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two left over from the rating fixes: Westside Pike, and an adjective
that echoes the Prancing Pony.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merge remote-tracking branch 'origin/design/1328-fill-it-in' into feat/1257-rating-fixes
Some checks failed
CI / Does this change touch the recording path? (pull_request) Successful in 34s
Details
CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been skipped
Details
CI / Bot/backend version sync (pull_request) Successful in 49s
Details
CI / Backend lint (ruff) (pull_request) Successful in 59s
Details
CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 1m5s
Details
CI / Which journeys does this change need? (pull_request) Successful in 32s
Details
CI / Feedback site tests (pull_request) Successful in 1m46s
Details
CI / Bot tests and audit (pull_request) Successful in 2m13s
Details
CI / Docker image build (pull_request) Successful in 6m35s
Details
CI / End-to-end journeys (desktop) (pull_request) Has been skipped
Details
CI / Frontend (shard 2/2) (pull_request) Successful in 9m39s
Details
CI / Frontend (shard 1/2) (pull_request) Failing after 10m43s
Details
CI / Backend migration, tests, and audit (pull_request) Successful in 36m0s
Details
9af7781191 
# Conflicts:
#	tools/feedback-site/app.py
#	tools/feedback-site/tests/test_app.py
claude-bot commented 2026-11-04 00:48:50 +00:00
Author
Collaborator
Copy link

This PR's commits landed in main through #1331, which was built on this branch and merged on 2026-11-04 with the owner's approval. Closing it as landed. The rating fixes and lanes 6k and 6l are live and on main.

This PR's commits landed in main through #1331, which was built on this branch and merged on 2026-11-04 with the owner's approval. Closing it as landed. The rating fixes and lanes 6k and 6l are live and on main.
claude-bot closed this pull request 2026-11-04 00:48:51 +00:00
Some checks failed
CI / Does this change touch the recording path? (pull_request) Successful in 34s
Required
Details
CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been skipped
Required
Details
CI / Bot/backend version sync (pull_request) Successful in 49s
Required
Details
CI / Backend lint (ruff) (pull_request) Successful in 59s
Required
Details
CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 1m5s
Required
Details
CI / Which journeys does this change need? (pull_request) Successful in 32s
Required
Details
CI / Feedback site tests (pull_request) Successful in 1m46s
Required
Details
CI / Bot tests and audit (pull_request) Successful in 2m13s
Required
Details
CI / Docker image build (pull_request) Successful in 6m35s
Required
Details
CI / End-to-end journeys (desktop) (pull_request) Has been skipped
Required
Details
CI / Frontend (shard 2/2) (pull_request) Successful in 9m39s
Required
Details
CI / Frontend (shard 1/2) (pull_request) Failing after 10m43s
Required
Details
CI / Backend migration, tests, and audit (pull_request) Successful in 36m0s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend
Issue related to the backend

  
bot
Issue related to the bot

  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
frontend
Issue related to the frontend

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
recording
Issue related to the recording system

  
security
Security hardening / vulnerability work

  
wontfix
This won't be fixed

No labels
backend
bot
bug
duplicate
enhancement
frontend
help wanted
invalid
question
recording
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rbrooks/Quest-Board!1330
No description provided.