Cleanup after the name generator: the old AI names code, and only used runs kept (#1345) #1353

Merged

claude-bot merged 5 commits from chore/1345-names-cleanup into main 2026-11-06 21:03:41 +00:00

Conversation 0 Commits 5 Files changed 10 +267 -284

claude-bot commented 2026-11-06 07:27:27 +00:00

Collaborator

Copy link

Findings for #1345.

1. Old AI names code. audio_service.generate_name_options had no caller outside tests: the session route POST /sessions/{id}/name-options/generate (its handler shares the name) runs the names Workbench tool, which draws from app/names/ through name_service.draw. Prep's Names drawer uses that, and Describe uses name_service.describe, which does not touch what was removed. Removed: the function, _NAME_CATEGORY_DESCRIPTION_HINTS, _NAME_CATEGORY_DESCRIPTION_HINTS_BY_SYSTEM, _NAME_GENERATOR_SYSTEM_PROMPT, the three pf2e/free-form/dnd5e hint tests, and the generate_name_options half of test_names_sends_its_schema. Kept: NAME_OPTIONS_SCHEMA (the names tool's output schema, used by generation_service).

2. Names runs. A "names run" is a generation_results row with tool_id='names'. Every draw is persisted (sheet route and Planning both go through run_and_record), plus one name_offers row per name. The old retention kept an unused run for 30 days. A draw reads name_offers and the wiki titles and aliases (name_service.excluded_keys), never generation_results, so name_offers alone gives "never twice" and is untouched.

Signals for "used": a run in a prep sheet or For later (kept_clause, "Keep it") was already recorded. Saving to the wiki records no link to the run (Planning calls createLoreEntry, a sheet calls canonical-names), and "copied" is client-only, recorded nowhere. So a run counts as used when kept_clause holds it, or one of its names (compared by name_key) is now a live wiki page title or alias in the same campaign. Copying does not count.

Done: generation_result_service.delete_unused_names_runs (24 h), called from the existing daily prune_generation_results task. No migration.

Closes #1345.

🤖 Generated with Claude Code

Findings for #1345. **1. Old AI names code.** `audio_service.generate_name_options` had no caller outside tests: the session route `POST /sessions/{id}/name-options/generate` (its handler shares the name) runs the `names` Workbench tool, which draws from `app/names/` through `name_service.draw`. Prep's Names drawer uses that, and Describe uses `name_service.describe`, which does not touch what was removed. Removed: the function, `_NAME_CATEGORY_DESCRIPTION_HINTS`, `_NAME_CATEGORY_DESCRIPTION_HINTS_BY_SYSTEM`, `_NAME_GENERATOR_SYSTEM_PROMPT`, the three pf2e/free-form/dnd5e hint tests, and the `generate_name_options` half of `test_names_sends_its_schema`. Kept: `NAME_OPTIONS_SCHEMA` (the `names` tool's output schema, used by `generation_service`). **2. Names runs.** A "names run" is a `generation_results` row with `tool_id='names'`. Every draw is persisted (sheet route and Planning both go through `run_and_record`), plus one `name_offers` row per name. The old retention kept an unused run for 30 days. A draw reads `name_offers` and the wiki titles and aliases (`name_service.excluded_keys`), never `generation_results`, so `name_offers` alone gives "never twice" and is untouched. Signals for "used": a run in a prep sheet or For later (`kept_clause`, "Keep it") was already recorded. Saving to the wiki records no link to the run (Planning calls `createLoreEntry`, a sheet calls `canonical-names`), and "copied" is client-only, recorded nowhere. So a run counts as used when `kept_clause` holds it, or one of its names (compared by `name_key`) is now a live wiki page title or alias in the same campaign. Copying does not count. Done: `generation_result_service.delete_unused_names_runs` (24 h), called from the existing daily `prune_generation_results` task. No migration. Closes #1345. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 3 commits 2026-11-06 07:27:28 +00:00

chore(webapp): remove the old AI names code, keep only used names runs (#1345) ... 59707fc073

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

style: ruff format, drop unused import (#1345) ... cbb36228e8

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test: use a real names style in the sweep test (#1345) ... 84f05c3b69

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rbrooks added 2 commits 2026-11-06 10:16:44 +00:00

test: list the sweep's title read (#1345) ... 52fa8bc767

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

style: ruff format (#1345) ... 908e63fce7

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot merged commit 6b7b0e0397 into main 2026-11-06 21:03:41 +00:00

claude-bot referenced this pull request from a commit 2026-11-06 21:03:43 +00:00

Merge pull request 'Cleanup after the name generator: the old AI names code, and only used runs kept (#1345)' (#1353) from chore/1345-names-cleanup into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1353

No description provided.