Cleanup after #1257: remove audio_service.generate_name_options, and keep only names runs that were used #1345

New issue

Closed

opened 2026-11-06 01:34:08 +00:00 by claude-bot · 1 comment

claude-bot commented

2026-11-06 01:34:08 +00:00

Collaborator

Two leftovers from the built-in name generator (#1257, 4.7.0). Neither is visible to users.

audio_service.generate_name_options was the AI path behind Prep's old Names drawer. Since #1257, Prep draws from the built-in engine (app/names/), and "Describe" is the only AI path left. Find the remaining callers and tests, remove the function and anything that only it used, and make sure no route or task still reaches it.
Names runs: keep only the runs that were used, meaning a name was saved to the wiki or copied. Today every draw is kept. Prune unused runs after a short window, and leave name_offers alone: it's the campaign's "never offer the same name twice" memory and must outlive the runs. Check first whether that table alone gives "never twice", or whether a run is needed for it, and write down what was found.

Tests for both. A migration only if (2) needs one.

Two leftovers from the built-in name generator (#1257, 4.7.0). Neither is visible to users. 1. **`audio_service.generate_name_options`** was the AI path behind Prep's old Names drawer. Since #1257, Prep draws from the built-in engine (`app/names/`), and "Describe" is the only AI path left. Find the remaining callers and tests, remove the function and anything that only it used, and make sure no route or task still reaches it. 2. **Names runs:** keep only the runs that were used, meaning a name was saved to the wiki or copied. Today every draw is kept. Prune unused runs after a short window, and leave `name_offers` alone: it's the campaign's "never offer the same name twice" memory and must outlive the runs. Check first whether that table alone gives "never twice", or whether a run is needed for it, and write down what was found. Tests for both. A migration only if (2) needs one.

claude-bot added this to the v4.8.0 - A Living World Fills In milestone

2026-11-06 01:34:19 +00:00

rbrooks referenced this issue from a commit

2026-11-06 07:27:03 +00:00

chore(webapp): remove the old AI names code, keep only used names runs (#1345)

rbrooks referenced this issue from a commit

2026-11-06 07:27:03 +00:00

style: ruff format, drop unused import (#1345)

rbrooks referenced this issue from a commit

2026-11-06 07:27:03 +00:00

test: use a real names style in the sweep test (#1345)

claude-bot commented

2026-11-06 07:27:25 +00:00

Author

Collaborator

Findings for #1345.

1. Old AI names code. audio_service.generate_name_options had no caller outside tests: the session route POST /sessions/{id}/name-options/generate (its handler shares the name) runs the names Workbench tool, which draws from app/names/ through name_service.draw. Prep's Names drawer uses that, and Describe uses name_service.describe, which does not touch what was removed. Removed: the function, _NAME_CATEGORY_DESCRIPTION_HINTS, _NAME_CATEGORY_DESCRIPTION_HINTS_BY_SYSTEM, _NAME_GENERATOR_SYSTEM_PROMPT, the three pf2e/free-form/dnd5e hint tests, and the generate_name_options half of test_names_sends_its_schema. Kept: NAME_OPTIONS_SCHEMA (the names tool's output schema, used by generation_service).

2. Names runs. A "names run" is a generation_results row with tool_id='names'. Every draw is persisted (sheet route and Planning both go through run_and_record), plus one name_offers row per name. The old retention kept an unused run for 30 days. A draw reads name_offers and the wiki titles and aliases (name_service.excluded_keys), never generation_results, so name_offers alone gives "never twice" and is untouched.

Signals for "used": a run in a prep sheet or For later (kept_clause, "Keep it") was already recorded. Saving to the wiki records no link to the run (Planning calls createLoreEntry, a sheet calls canonical-names), and "copied" is client-only, recorded nowhere. So a run counts as used when kept_clause holds it, or one of its names (compared by name_key) is now a live wiki page title or alias in the same campaign. Copying does not count.

Done: generation_result_service.delete_unused_names_runs (24 h), called from the existing daily prune_generation_results task. No migration.

Findings for #1345. **1. Old AI names code.** `audio_service.generate_name_options` had no caller outside tests: the session route `POST /sessions/{id}/name-options/generate` (its handler shares the name) runs the `names` Workbench tool, which draws from `app/names/` through `name_service.draw`. Prep's Names drawer uses that, and Describe uses `name_service.describe`, which does not touch what was removed. Removed: the function, `_NAME_CATEGORY_DESCRIPTION_HINTS`, `_NAME_CATEGORY_DESCRIPTION_HINTS_BY_SYSTEM`, `_NAME_GENERATOR_SYSTEM_PROMPT`, the three pf2e/free-form/dnd5e hint tests, and the `generate_name_options` half of `test_names_sends_its_schema`. Kept: `NAME_OPTIONS_SCHEMA` (the `names` tool's output schema, used by `generation_service`). **2. Names runs.** A "names run" is a `generation_results` row with `tool_id='names'`. Every draw is persisted (sheet route and Planning both go through `run_and_record`), plus one `name_offers` row per name. The old retention kept an unused run for 30 days. A draw reads `name_offers` and the wiki titles and aliases (`name_service.excluded_keys`), never `generation_results`, so `name_offers` alone gives "never twice" and is untouched. Signals for "used": a run in a prep sheet or For later (`kept_clause`, "Keep it") was already recorded. Saving to the wiki records no link to the run (Planning calls `createLoreEntry`, a sheet calls `canonical-names`), and "copied" is client-only, recorded nowhere. So a run counts as used when `kept_clause` holds it, or one of its names (compared by `name_key`) is now a live wiki page title or alias in the same campaign. Copying does not count. Done: `generation_result_service.delete_unused_names_runs` (24 h), called from the existing daily `prune_generation_results` task. No migration.

claude-bot referenced this issue from a pull request that will close it,

2026-11-06 07:27:27 +00:00

Cleanup after the name generator: the old AI names code, and only used runs kept (#1345) #1353

rbrooks referenced this issue from a commit

2026-11-06 10:16:43 +00:00

test: list the sweep's title read (#1345)

rbrooks referenced this issue from a commit

2026-11-06 10:16:43 +00:00

style: ruff format (#1345)

claude-bot closed this issue

2026-11-06 21:03:42 +00:00

claude-bot referenced this issue from a commit