feat: shelf end-of-session sweep — promote / carry / discard (#247) #257

Merged

claude-bot merged 4 commits from feat/shelf-sweep into main 2026-07-24 21:49:10 +00:00

Conversation 0 Commits 4 Files changed 16 +1188 -27

claude-bot commented 2026-07-24 18:15:33 +00:00

Contributor

Copy link

The end-of-session sweep for the Session Reference Shelf (#247): at session end, one-tap triage of every card on tonight's shelf — Promote to wiki, Carry forward, or Discard — turning improv into canon in one pass.

Promote to wiki (the new work)

A new promote lore-draft mode + an LLM pass (promote_lore_entry_body) that cleans a card's live-play scratch content into a polished, merged wiki-entry body, reviewed through the existing per-entry draft-review rail. The target is decided by promote_card:

• lore card → a clean-up draft on its own entry;
• generation/note card whose inferred type + title matches an approved entry → a merge draft into that entry;
• no match → the entry is created immediately from the card's derived text (a stub), then a clean-up draft runs on it.

POST /api/sessions/{id}/shelf/{card_id}/promote → {entry_id, draft_id} hands off to /lore/{entry_id}/draft. Carry forward = the pin (built in #254); Discard = delete.

Why the stub approach

The draft rail is entirely per-entry (approve_draft → update_lore_entry; review URL is /lore/{entry_id}/draft). A null-entry "new-entry draft" would need a parallel review UI. Creating the entry up front from the card's real content (then AI-polishing) reuses the whole rail — one enum value, no review-UI changes.

Frontend

The "End-of-session sweep" panel (from the shelf header) lists every card with the three actions; promote links to its draft in a new tab so the sweep stays put.

Notes

• Migration c8d9e0f1a2b3 — ALTER TYPE loredraftmode ADD VALUE 'promote' (autocommit block, mirrors the convert_stats migration). No bot-contract change.
• Verified: 6 new promote tests, 32 across the shelf suite, no regressions; ruff + eslint clean.

Closes #247. Part of #235.

🤖 Generated with Claude Code

The end-of-session sweep for the Session Reference Shelf (#247): at session end, one-tap triage of every card on tonight's shelf — **Promote to wiki**, **Carry forward**, or **Discard** — turning improv into canon in one pass. ## Promote to wiki (the new work) A new `promote` lore-draft mode + an LLM pass (`promote_lore_entry_body`) that cleans a card's live-play scratch content into a polished, merged wiki-entry body, reviewed through the **existing per-entry draft-review rail**. The target is decided by `promote_card`: - **lore card** → a clean-up draft on its own entry; - **generation/note card** whose inferred type + title **matches an approved entry** → a merge draft into that entry; - **no match** → the entry is created immediately from the card's derived text (a stub), then a clean-up draft runs on it. `POST /api/sessions/{id}/shelf/{card_id}/promote → {entry_id, draft_id}` hands off to `/lore/{entry_id}/draft`. **Carry forward** = the pin (built in #254); **Discard** = delete. ### Why the stub approach The draft rail is entirely per-entry (`approve_draft → update_lore_entry`; review URL is `/lore/{entry_id}/draft`). A null-entry "new-entry draft" would need a parallel review UI. Creating the entry up front from the card's real content (then AI-polishing) reuses the whole rail — one enum value, no review-UI changes. ## Frontend The **"End-of-session sweep"** panel (from the shelf header) lists every card with the three actions; promote links to its draft in a new tab so the sweep stays put. ## Notes - Migration `c8d9e0f1a2b3` — `ALTER TYPE loredraftmode ADD VALUE 'promote'` (autocommit block, mirrors the convert_stats migration). No bot-contract change. - Verified: 6 new promote tests, 32 across the shelf suite, no regressions; ruff + eslint clean. Closes #247. Part of #235. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 2 commits 2026-07-24 18:15:33 +00:00

feat(backend): promote a shelf card to a wiki entry via AI draft (#247) ... 7b5a7392e2

The "promote to wiki" arm of the end-of-session sweep. Adds a `promote` lore
draft mode (migration c8d9e0f1a2b3, ADD VALUE on the loredraftmode enum) + an
`promote_lore_entry_body` LLM pass that turns a card's live-play scratch content
into a clean, merged wiki-entry body.

`promote_card` decides the target through the existing per-entry draft rail
(stub approach — no new review UI):
- lore card → clean-up draft on its own entry;
- generation/note card matching an approved entry (by inferred type + title) →
  merge draft into that entry;
- otherwise → create the entry immediately from the card's derived text (a
  stub), then a clean-up draft on it.
POST /api/sessions/{id}/shelf/{card_id}/promote → {entry_id, draft_id}, handing
off to the /lore/{entry_id}/draft review page. 6 new tests (32 with the shelf
suite), no regressions.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

feat(frontend): end-of-session sweep panel (#247) ... 302a8cc98b

A "Strike the set" sweep from the shelf header: triage every card on tonight's
shelf — Promote to wiki (creates/targets an entry + AI clean-up draft, links to
the review page in a new tab), Carry forward (pin), or Discard. Per-row status;
one pass turns improv into canon.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

claude-bot added this to the v3.11.0 - Session Reference Shelf milestone 2026-07-24 18:15:43 +00:00

rbrooks added 1 commit 2026-07-24 18:50:03 +00:00

chore(ci): allowlist the react-router RSC-mode advisory in the audit gate (#247) ... 9c82e46926

The frontend high/critical prod-audit gate went red repo-wide on a freshly
disclosed react-router advisory (GHSA-qwww-vcr4-c8h2, RSC Mode CSRF Bypass,
7.12.0–8.2.0) with no patched release yet. This is a client-side SPA that does
not use RSC mode, so the advisory doesn't apply. `npm audit` can't exclude a
single advisory, so the gate now filters its JSON via scripts/audit-allowlist.mjs
— a new high/critical vuln still blocks, only the allowlisted one is ignored.
Remove the allowlist entry once react-router ships a fix.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

rbrooks added 1 commit 2026-07-24 21:25:39 +00:00

fix(shelf): draw-item add-to-shelf + promote folds tonight-notes (#247, #155) ... 8fd112a8e8

Two issues surfaced testing the sweep:

- Instant NPC (a #155 draw-pool tool) returns an ephemeral item with no
  persisted GenerationResult, so "Add to shelf" (which required a
  generation_result_id) never appeared. Generation cards can now be added by a
  self-sufficient inline snapshot (card_kind=generation + generation_tool_id +
  generation_output); GeneratorPanel passes that for draw-mode results.
- Promote seeded the wiki entry from the card's content only, dropping the GM's
  tonight-notes. promote_card now folds tonight-notes into the drafted entry
  (kept in the stub body so they survive a discarded draft).

+2 tests (inline draw add; promote folds notes); 34 across the shelf + promote
suites.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

claude-bot merged commit d7cd7b2526 into main 2026-07-24 21:49:10 +00:00

claude-bot deleted branch feat/shelf-sweep 2026-07-24 21:49:10 +00:00

claude-bot referenced this pull request from a commit 2026-07-24 21:49:12 +00:00

Merge PR #257: shelf end-of-session sweep — promote / carry / discard (#247)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

v3.11.0 - Session Reference Shelf

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!257

No description provided.