Lane 11 PR 9: the sheet page, read (#737) #972

Merged

claude-bot merged 6 commits from build/lane11-9-sheet-page into main 2026-09-30 13:09:57 +00:00

Conversation 0 Commits 6 Files changed 20 +3315 -18

claude-bot commented 2026-09-30 11:47:49 +00:00

Collaborator

Copy link

Part of #737 (lane 11, character sheets), PR 9 of the build contract (docs/design/lane11-build-contract.md). This adds the page for reading a sheet; editing comes in PR 10.

What's new

• Route: /campaigns/:cid/wiki/:entryId/sheet, a document of its own. "Open the sheet" on the article leads there. A page that is not a person or a creature says it has no sheet.
• Pages: Statistics, Abilities & inventory, Notes & actions, and Spells for a caster. They are in the Contents (useContents gains a sheet place) and, on a phone, in the Contents sheet.
• Rendering: everything is drawn from the system's definition (pages/sheet/model.js, Fields.jsx, SheetBody.jsx), so PF2e, 5e and the generic sheet are one page. The page shows:
  • every figure once, with its derivation beneath it (on tap on a phone);
  • ranks, HP, dying, wounded and hero points;
  • strikes worked out from the inventory;
  • feats by level;
  • the inventory with its bulk and where each thing is;
  • spells by rank with the slots left;
  • the character's actions with their cost and full text.
• Edge cases:
  • An item whose pack has gone keeps its last numbers and says so.
  • Groups a player keeps for themselves, and groups for the GM, wear the GM colour.
  • A reader who may not edit is told so quietly.
• Export and print: Export gives Quest Board JSON (route #11), and Print the sheet prints every page (@media print).
• Lane 0: ui/Derivation hides zero-value terms when another term is non-zero, and prints a constant term once.
• Class name: the page's root class is .charsheet, because .sheet collided with the Contents panel.

Checks

• Render-checked at 390×844 and 1440 in both themes against lane9.html. That round found the .sheet class collision, the label, the place before load, the pill, the actions, the menu, the header row, zero terms, scroll regions, one-page sheets and print, all fixed in 02e79e26.
• Axe is clean.
• SheetPage.test.jsx (816 lines) runs on the shared conformance fixtures via sheetFixtures.js. Article, useContents and Derivation tests are updated.
• Changelog: changelog.d/737-lane11-sheet-page.added.md.

🤖 Generated with Claude Code

Part of #737 (lane 11, character sheets), PR 9 of the build contract (`docs/design/lane11-build-contract.md`). This adds the page for reading a sheet; editing comes in PR 10. **What's new** - **Route:** `/campaigns/:cid/wiki/:entryId/sheet`, a document of its own. "Open the sheet" on the article leads there. A page that is not a person or a creature says it has no sheet. - **Pages:** Statistics, Abilities & inventory, Notes & actions, and Spells for a caster. They are in the Contents (`useContents` gains a sheet place) and, on a phone, in the Contents sheet. - **Rendering:** everything is drawn from the system's definition (`pages/sheet/model.js`, `Fields.jsx`, `SheetBody.jsx`), so PF2e, 5e and the generic sheet are one page. The page shows: - every figure once, with its derivation beneath it (on tap on a phone); - ranks, HP, dying, wounded and hero points; - strikes worked out from the inventory; - feats by level; - the inventory with its bulk and where each thing is; - spells by rank with the slots left; - the character's actions with their cost and full text. - **Edge cases:** - An item whose pack has gone keeps its last numbers and says so. - Groups a player keeps for themselves, and groups for the GM, wear the GM colour. - A reader who may not edit is told so quietly. - **Export and print:** Export gives Quest Board JSON (route #11), and Print the sheet prints every page (`@media print`). - **Lane 0:** `ui/Derivation` hides zero-value terms when another term is non-zero, and prints a constant term once. - **Class name:** the page's root class is `.charsheet`, because `.sheet` collided with the Contents panel. **Checks** - Render-checked at 390×844 and 1440 in both themes against lane9.html. That round found the `.sheet` class collision, the label, the place before load, the pill, the actions, the menu, the header row, zero terms, scroll regions, one-page sheets and print, all fixed in 02e79e26. - Axe is clean. - `SheetPage.test.jsx` (816 lines) runs on the shared conformance fixtures via `sheetFixtures.js`. `Article`, `useContents` and `Derivation` tests are updated. - Changelog: `changelog.d/737-lane11-sheet-page.added.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 6 commits 2026-09-30 11:47:50 +00:00

WIP lane 11 PR 9: the sheet page, read (model, fields, body, page, Contents place) ... 896a5a29aa

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

WIP lane 11 PR 9: tests, Contents place, Article link, fixes ... 60fff11d66

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Lane 11 PR 9: the sheet page, read (#737): changelog, pages strip touch size ... d18a9bb486

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Merge origin/main into build/lane11-9-sheet-page bf70c3e075

Lane 11 PR 9: render-check fixes (class collision, label, place before load, pill, actions, menu, header row, zero terms, scroll regions, one-page sheets, print test) ... 02e79e268c

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into build/lane11-9-sheet-page 209d4e1da4

claude-bot merged commit 008add3821 into main 2026-09-30 13:09:57 +00:00

claude-bot referenced this pull request from a commit 2026-09-30 13:09:59 +00:00

Merge PR #972: lane 11 PR 9 — the sheet page, read (#737)

claude-bot referenced this pull request 2026-09-30 13:31:52 +00:00

Lane 11 PR 10: edit a sheet, and it saves itself (#737) #975

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!972

No description provided.